Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.amqp-utils: fix amqp-0.19 dependency #80509

Closed
wants to merge 1 commit into from

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Feb 19, 2020

Motivation for this change

un-break amqp-utils by declaring the amqp-0.19 dependency

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

@woffs Thanks for sending this fix.

amqp actually looks like it will get bumped to 0.19 for the upcoming LTS-15, which should mean that you don't have to override amqp:

#79819

Can you rebase this on haskell-updates and remove the override?

Also, for future reference, the hackage-packages.nix file is generated automatically, so please don't edit it.

@cdepillabout
Copy link
Member

Also, if you were willing to put amqp-utils in stackage, that would mean it would most likely continue working in the future without having to do anything special in nixpkgs.

@woffs
Copy link
Contributor Author

woffs commented Feb 19, 2020

Thank you @cdepillabout . https://www.stackage.org/lts-15.0 lists amqp-0.19.1, but configuration-hackage2nix.yaml in haskell-updates is still LTS-14.25 with amqp-0.18.3 listed. Maybe I only need to wait some hours until this is updated to LTS-15.0 and my PR can be closed anyway?

And I was not aware that I could put my package into stackage, and I will find out how to do this. Thank you for the hint!

@cdepillabout
Copy link
Member

cdepillabout commented Feb 19, 2020

Maybe I only need to wait some hours until this is updated to LTS-15.0 and my PR can be closed anyway?

Yeah, I think you will only need to wait a few days until that PR actually updates to LTS-15.0.

After that happens, please send another PR to the haskell-updates branch marking amqp-utils as non-broken.

@woffs woffs closed this Feb 19, 2020
@woffs
Copy link
Contributor Author

woffs commented Feb 23, 2020

amqp-utils now builds fine on haskell-updates and is marked non-broken already.
Will LTS-15.0 go into nixos-20.03 as well or id the dependency to be fixed manually for 20.03?

@cdepillabout
Copy link
Member

LTS-15.0 go into nixos-20.03

Yeah, peti is planning on doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants