Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brotab: 1.1.0 -> 1.2.1 #80522

Merged
merged 1 commit into from Mar 30, 2020
Merged

brotab: 1.1.0 -> 1.2.1 #80522

merged 1 commit into from Mar 30, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Feb 19, 2020 •
edited

Cleanup deps a little bit.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar doronbehar changed the title brotab: 1.1.0 -> 1.2.0 WIP brotab: 1.1.0 -> 1.2.0 Feb 19, 2020
@doronbehar doronbehar changed the title WIP brotab: 1.1.0 -> 1.2.0 [WIP] brotab: 1.1.0 -> 1.2.0 Feb 19, 2020
@doronbehar

This comment has been minimized.

Sign in to view
@doronbehar doronbehar mentioned this pull request Feb 19, 2020
Closed
@doronbehar
brotab: 1.1.0 -> 1.2.1
896f19d 
Cleanup and fix deps a little bit.
@doronbehar doronbehar changed the title [WIP] brotab: 1.1.0 -> 1.2.0 brotab: 1.1.0 -> 1.2.1 Feb 19, 2020
bhipple
bhipple approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 80522 1

1 package built: - brotab

@bhipple bhipple merged commit ecfb2b4 into NixOS:master Mar 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @bhipple