Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slurm: improve RDMA capability #80617

Merged
merged 2 commits into from Feb 22, 2020
Merged

Slurm: improve RDMA capability #80617

merged 2 commits into from Feb 22, 2020

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change

split from #79771

Things done

make SLURM aware of rdma-core as well as increase the ulimit of the slurm service.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from jagajaga February 20, 2020 09:31
@markuskowa
Copy link
Member

markuskowa commented Feb 20, 2020 •
edited

@GrahamcOfBorg test slurm

@markuskowa
Copy link
Member

Can you please change the commit message to:
"slrum/nixos: increase ulimit for IB/RDMA" to indicate that it is nixos related

@markuskowa markuskowa merged commit 74dcd1c into NixOS:master Feb 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa Awaiting requested review from markuskowa

@jagajaga jagajaga Awaiting requested review from jagajaga

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ikervagyok @markuskowa