python.pkgs.scikits-odes: 2.4.0-9-g93075ae -> 2.6.1 #80540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This package has only been used for python.pkgs.scikits-odes, which should compile with sundials 5 by now.
This was referenced Feb 19, 2020
doronbehar
reviewed
Feb 19, 2020
| @@ -14398,8 +14398,6 @@ in | |||
|
|
|||
| sundials = callPackage ../development/libraries/sundials { }; | |||
There was a problem hiding this comment.
@flokli perhaps in order to avoid merge conflicts get a little bit rid of python2 dependence and so this PR will play along better with #79864 , maybe we should switch the python version of sundials uses here instead of in #79864?
Suggested change
| sundials = callPackage ../development/libraries/sundials { }; | |
| sundials = callPackage ../development/libraries/sundials { | |
| python = python3; | |
| }; |
There was a problem hiding this comment.
It's unrelated to the package bump - I'd rather see that in a separate commit in #79864.
idontgetoutmuch
approved these changes
Feb 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This bumps
scikits-odesto the latest release, which is compatible with sundials 5.1.0, so we can get rid ofsundials_3, which was only used there.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)