Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heatseeker: 1.5.1 -> 1.7.1 #80539

Closed
wants to merge 1 commit into from
Closed

heatseeker: 1.5.1 -> 1.7.1 #80539

wants to merge 1 commit into from

Conversation

michaelpj
Copy link
Contributor

The old version is broken on our version of Rust.

Needed patching to fix rschmitt/heatseeker#42.

Also get rid of legacyCargoFetcher as desired by
#79975.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)Rust Application Migration to fetchCargoTarball Implementation #79975
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bhipple
bhipple requested changes Feb 19, 2020
View reviewed changes
pkgs/tools/misc/heatseeker/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/heatseeker/default.nix Outdated Show resolved Hide resolved
@michaelpj
heatseeker: 1.5.1 -> 1.7.1
1281ae3 
The old version is broken on our version of Rust.

Needed patching to fix rschmitt/heatseeker#42.

Also get rid of `legacyCargoFetcher` as desired by
NixOS#79975.
@michaelpj
Copy link
Contributor Author

Comments addressed, thanks.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/105

@michaelpj michaelpj mentioned this pull request Mar 9, 2020
Merged
10 tasks
@michaelpj michaelpj closed this Mar 9, 2020
@michaelpj michaelpj mentioned this pull request Apr 7, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use /usr/bin/env to find stty
3 participants
@michaelpj @nixos-discourse @bhipple