Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #80542 from xfix/acme-fix-a-example-com-test #80542

Merged

Conversation

KamilaBorowska
Copy link
Member

Based on 636eb23

Motivation for this change

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg test acme

@Frostman
Copy link
Member

nixpkgs-review pr 80542 -p nixosTests.acme passed ok. Change LGTM.

@arianvp
Copy link
Member

arianvp commented Feb 19, 2020

Thanks but as noted in the original PR #77578 (comment)

this is a bit of a hack and not a sustainable fix. We shouldn't be adding dependencies to the test that aren't present in the actual code (Except for the .target probes )

Was the test actually failing on Hydra for a.example.com or did you copy it over because it was there for b.example.com too ?

Anyhow lets merge this for now. but lets open an issue that we should stabilise either the tests, or fix the root cause in the acme module.

cc @flokli

@disassembler disassembler changed the title nixos/acme: Fix a.example.com test Merge pull request #80542 from xfix/acme-fix-a-example-com-test Feb 19, 2020
@disassembler disassembler merged commit 1b3176b into NixOS:master Feb 19, 2020
@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Feb 19, 2020

Was the test actually failing on Hydra for a.example.com or did you copy it over because it was there for b.example.com too ?

It was failing for me locally without this change. There was a commit that specifically added this for b.example.com, so I also added it for a.example.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants