Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: Correct xdg-open behavior #80629

Merged
merged 1 commit into from Feb 20, 2020
Merged

alacritty: Correct xdg-open behavior #80629

merged 1 commit into from Feb 20, 2020

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Feb 20, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Mic92 and Br1ght0ne February 20, 2020 13:29
@Mic92
Copy link
Member

Mic92 commented Feb 20, 2020

Looks like git is broken right now.

@grahamc
Copy link
Member Author

grahamc commented Feb 20, 2020

Eh, that's fine. I built it locally and it works great :)

@grahamc grahamc merged commit f3f836b into NixOS:master Feb 20, 2020
@grahamc grahamc deleted the alacritty-xdg-open-again branch February 20, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@grahamc @Mic92