Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

freeorion: fix build fail #80566

Merged
merged 1 commit into from Feb 25, 2020
Merged

freeorion: fix build fail #80566

merged 1 commit into from Feb 25, 2020

Conversation

tex
Copy link
Contributor

@tex tex commented Feb 19, 2020

fixes #79805

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27
Copy link
Member

Ma27 commented Feb 19, 2020

When I try to run freeorion with your fix I get the following error:

Unable to load OpenGL entry points.

GLEW reported:
Unknown error
terminate called after throwing an instance of '(anonymous namespace)::QuitSignal'
[1]    20095 abort (core dumped)  ./result/bin/freeorion

May I ask if I'm probably missing something in my environment or if that's an actual issue with the package? :)

@tex
Copy link
Contributor Author

tex commented Feb 20, 2020

Must be something in your environment. I played the game for an hour (lost against AI :) ), saw no crash, no issues. Game quit without any errors when I wanted.

I run it in nix-shell -p freeorion

@tex
Copy link
Contributor Author

tex commented Feb 21, 2020 •
edited

Could you merge it? I do not want to recompile it every time after update :)

@Ma27
Copy link
Member

Ma27 commented Feb 25, 2020

Seems to be related to my desktop (sway/wayland).

@Ma27 Ma27 merged commit 7abc41c into NixOS:master Feb 25, 2020
@tex tex deleted the patch-1 branch February 25, 2020 21:22
@ajs124
Copy link
Member

ajs124 commented Apr 9, 2020

cherry picking this to release-20.03 seems to fix the build there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tex @Ma27 @ajs124