Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.debian: 4.0.0r1 -> 4.0.2 #80564

Closed
wants to merge 1 commit into from
Closed

haskellPackages.debian: 4.0.0r1 -> 4.0.2 #80564

wants to merge 1 commit into from

Conversation

neilmayhew
Copy link
Member

@neilmayhew neilmayhew commented Feb 19, 2020 •
edited

Motivation for this change

This package currently fails to build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@cdepillabout
Copy link
Member

@neilmayhew Thanks for taking the time to try to fix this.

However, hackage-packages.nix is an autogenerated file, so any changes to it will get overwritten next time it is autogenerated.

Please see this video on how to mark Haskell packages as unbroken:

https://discourse.nixos.org/t/video-tutorial-how-to-fix-broken-haskell-packages-in-nix/3968

Also, please send haskell-related changes to the haskell-updates branch, not master.

On the haskell-updates branch, this debian package is probably already version 4.0.2, so you will most likely just have to mark it non-broken, not actually bump the version number.

@peti peti closed this Feb 28, 2020
@neilmayhew neilmayhew deleted the fix/haskell-debian branch May 16, 2020 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@neilmayhew @cdepillabout @peti