Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] nixos/tinydns: use local dns server to fix test (backport) #80567

Merged
merged 1 commit into from Feb 20, 2020
Merged

[20.03] nixos/tinydns: use local dns server to fix test (backport) #80567

merged 1 commit into from Feb 20, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 19, 2020 •
edited

(cherry picked from commit c8a8735)

Motivation for this change

Force host command to use a local DNS server for resolving.

ZHF: #80379

Backport of #80565

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
Copy link
Member Author

@GrahamcOfBorg test tinydns

@rnhmjoj rnhmjoj merged commit d9261c5 into NixOS:release-20.03 Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Frostman @rnhmjoj