Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 2ba67da0532c
Choose a base ref
...
head repository: NixOS/nix
compare: 2e953b567ebb
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Feb 19, 2020

  1. nix-shell: clean up the tmpDir and escape variables 

    The problem fixed: each nix-shell invocation creates a new temporary
directory (`/tmp/nix-shell-*`) and never cleans up.

And while I'm here, shellescape all variables inlined into the rcfile.
See what might happen without escaping:

    $ export TZ="';echo pwned'"
    $ nix-shell -p hello --run hello
    pwned
    Hello, world!
    @xzfc
    xzfc committed Feb 19, 2020
    Copy the full SHA
    f2a03ac View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3325 from xzfc/clean-tmpdir 

    nix-shell: clean up the tmpDir and escape variables
    @edolstra
    edolstra committed Feb 19, 2020
    Copy the full SHA
    2e953b5 View commit details
    Browse the repository at this point in the history