Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kitty: better fix for build error #80546

Merged
merged 2 commits into from Feb 19, 2020
Merged

kitty: better fix for build error #80546

merged 2 commits into from Feb 19, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Feb 19, 2020

Motivation for this change

Without the no-werror.patch, the compilation would fail with the following warning:

clang-7: error: argument unused during compilation: '-fno-strict-overflow' [-Werror,-Wunused-command-line-argument]

To fix this, the compiler command line options -pedantic-errors and -Werror were patched out of the build script so that the warning would not become an error and stop the build. This is not ideal as this piece of code is changed fairly frequently, which requires fixing the patch. In the next kitty version the patch would need to be fixed again.
A better alternative IMO is to just not pass -fno-strict-overflow to the compiler. This is done by disabling the strictoverflow hardening feature.

Is it ok to not remove the two compiler flags from the build script or were they needed for something else?

I also added myself as a maintainer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
maintainers: add Luflosi
ff80331
@Luflosi
kitty: better fix for build error
2a15e3b 
Without the `no-werror.patch`, the compilation would fail with the following warning:
```
clang-7: error: argument unused during compilation: '-fno-strict-overflow' [-Werror,-Wunused-command-line-argument]
```
To fix this, the compiler command line options `-pedantic-errors` and `-Werror` were patched out of the build script so that the warning would not become an error and stop the build. This is not ideal as this piece of code is changed fairly frequently, which requires fixing the patch. In the next kitty version the patch would need to be fixed again.
A better alternative is to just not pass `-fno-strict-overflow` to the compiler. This is done by disabling the `strictoverflow` hardening feature.
@ofborg ofborg bot requested a review from Ma27 February 19, 2020 16:52
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 19, 2020

@GrahamcOfBorg build kitty

rnhmjoj
rnhmjoj approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@rnhmjoj rnhmjoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm the key matches the one used to sign the commit and the github user ID is correct.

The fix seems much saner than a patch; if ofBorg builds it it's good to me.

@rnhmjoj rnhmjoj merged commit 7789299 into NixOS:master Feb 19, 2020
@Luflosi Luflosi deleted the kitty-disable-strictoverflow branch February 19, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnhmjoj rnhmjoj rnhmjoj approved these changes

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luflosi @rnhmjoj