Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.pandoc-crossref: downgrade to latest working #80556

Closed
wants to merge 2 commits into from
Closed

haskellPackages.pandoc-crossref: downgrade to latest working #80556

wants to merge 2 commits into from

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 19, 2020

Motivation for this change

As usual pandoc-crossref is broken because the pandoc version in LTS is too old.
I tested this by regenerating hackage-packages.nix and the package builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@rnhmjoj rnhmjoj requested a review from peti February 19, 2020 19:04
cdepillabout
cdepillabout reviewed Feb 20, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-hackage2nix.yaml Outdated
@@ -1539,6 +1539,7 @@ default-package-overrides:
- palette ==0.3.0.2
- pandoc ==2.7.3
- pandoc-citeproc ==0.16.2
- pandoc-crossref ==0.3.4.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved to the top of this list. See the comment on this list.

Alternatively, if you wanted to get pandoc-crossref in stackage, we wouldn't have to specifically deal with this in nixpkgs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I didn't notice. Done.

I don't know the process: should I just open an issue in commercialhaskell/stackage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stackage homepage has a few links with info on adding a package:

https://www.stackage.org/

In particular:

@cdepillabout
Copy link
Member

Oh, one more thing I should have added. Within the next week or so, nixpkgs will update to LTS-15.

Is this change still needed for LTS-15?

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 20, 2020 •
edited

Good point, no I don't know: it depends whether it will contain pandoc 2.9. I'll have to check.

EDIT:

Apparently it will be 2.9. Will this update backported to 20.03?

@cdepillabout
Copy link
Member

Apparently it will be 2.9. Will this update backported to 20.03?

I don't believe it will, although maybe @peti could clarify this?

If it is not backported, then on the release-20.03 branch, you can directly edit the hackage-packages.nix file, since it is no longer automatically updated.

However, we tend not to get many fixes for Haskell stuff to release branches, so I'm not sure exactly how this stuff should be handled.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 20, 2020

If it is not backported, then on the release-20.03 branch, you can directly edit the hackage-packages.nix file, since it is no longer automatically updated.

Ok, then I'll wait for a confirmation before opening another PR.

@peti
Copy link
Member

peti commented Feb 21, 2020

Will [lts-15 be] backported to 20.03?

I don't believe it will, although maybe @peti could clarify this?

Yes, I'll backport the lts-15.x update to the 20.03 release branch.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 21, 2020

Ok, thank you. I'll close the PR as it will not be needed

@rnhmjoj rnhmjoj closed this Feb 21, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Mar 21, 2020

Yes, I'll backport the lts-15.x update to the 20.03 release branch.

Any updates? It's been a while..

@rnhmjoj rnhmjoj deleted the pandoc-crossref branch April 7, 2020 12:43
@rnhmjoj rnhmjoj restored the pandoc-crossref branch April 7, 2020 12:44
@rnhmjoj rnhmjoj mentioned this pull request Apr 7, 2020
Merged
10 tasks
@rnhmjoj rnhmjoj deleted the pandoc-crossref branch June 19, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

@infinisil infinisil Awaiting requested review from infinisil

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rnhmjoj @cdepillabout @peti