Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r20.03] cargo-update: 1.5.2 -> 2.5.0 #80637

Merged
merged 1 commit into from Feb 20, 2020
Merged

[r20.03] cargo-update: 1.5.2 -> 2.5.0 #80637

merged 1 commit into from Feb 20, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Feb 20, 2020 •
edited

Motivation for this change

ZHF: #80379

This is a major upgrade, however I think it makes sense, considering cargo-update doesn't build on 20.03. It could be patched to build, but it makes more sense to upgrade the package, considering it never has worked on 20.03.

This isn't the newest version of cargo-update, but rather the one on master, but I think that's fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Br1ght0ne @KamilaBorowska
cargo-update: 1.5.2 -> 2.5.0
efdf679 
(cherry picked from commit 204b722)
@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build cargo-update

@ofborg ofborg bot requested a review from Gerschtli February 20, 2020 14:43
jonringer
jonringer approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[4 built, 12 copied (889.8 MiB), 258.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80637
1 package built:
cargo-update

@jonringer jonringer merged commit 645faf2 into NixOS:release-20.03 Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Gerschtli Gerschtli Awaiting requested review from Gerschtli

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KamilaBorowska @jonringer @Br1ght0ne