Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clojure: 1.10.1.507 -> 1.10.1.510 #80553

Closed
wants to merge 1 commit into from
Closed

clojure: 1.10.1.507 -> 1.10.1.510 #80553

wants to merge 1 commit into from

Conversation

jlesquembre
Copy link
Member

Motivation for this change

Update clojure

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

ping @hlolli , TDEPS-150 was fixed, your patch should not be needed anymore, could you confirm it?

@hlolli
Copy link
Member

hlolli commented Feb 19, 2020

Sure, I'll test tonight!

hlolli
hlolli approved these changes Feb 19, 2020
View reviewed changes
Copy link
Member

@hlolli hlolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, let's ship it ;)

/nix/store/34rd8kdckxpmvfwqbx0ayxdjyli22ll7-clojure-1.10.1.510
➜  nixpkgs git:(db4269a8949) result/bin/clojure                ~/nixpkgs
Clojure 1.10.1
user=> (println :a)
:a
nil
user=> (System/exit 0)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/162

@jlesquembre jlesquembre mentioned this pull request Jun 18, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hlolli hlolli hlolli approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jlesquembre @hlolli @nixos-discourse