Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brave: 1.3.115 -> 1.3.118 #80592

Merged
merged 1 commit into from Feb 22, 2020
Merged

brave: 1.3.115 -> 1.3.118 #80592

merged 1 commit into from Feb 22, 2020

Conversation

JeffLabonte
Copy link
Contributor

@JeffLabonte JeffLabonte commented Feb 20, 2020 •
edited

Motivation for this change
Things done

Update brave from 1.3.115 to 1.3.118

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JeffLabonte JeffLabonte requested review from worldofpeace and removed request for worldofpeace February 20, 2020 02:17
@ofborg ofborg bot requested a review from uskudnik February 20, 2020 02:31
turboMaCk
turboMaCk approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@turboMaCk turboMaCk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • binary builds and works on NixOS
  • diff is straight forward update

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/pull-reviewers-brave/5996/2

@samueldr samueldr merged commit 6510e08 into NixOS:master Feb 22, 2020
@samueldr
Copy link
Member

samueldr commented Feb 22, 2020 •
edited

I'll be handling the backport commits to the 20.03 (soon to be) stable branch, though I invite you to ask for a backport, or provide a backport PR for the stable branch for your next Brave PRs. Brave is a browser, browsers are one of the prime attack surface on a computer, it is important to keep them up-to-date in stable branches. (19.09 would need it too, in theory, but would need a bunch more backport commits to be handled.)

The manual has some information pertaining to backports. Though don't hesitate to ask, either in the main PR, discourse, IRC, if you have any questions about the backports process!

@samueldr samueldr mentioned this pull request Feb 22, 2020
Merged
9 tasks
@JeffLabonte
Copy link
Contributor Author

Thank you @samueldr !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turboMaCk turboMaCk turboMaCk approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@uskudnik uskudnik Awaiting requested review from uskudnik

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JeffLabonte @nixos-discourse @samueldr @turboMaCk