Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-cloud-sdk: fix Darwin build by only stripping local symbols #80554

Merged
merged 1 commit into from Feb 21, 2020
Merged

google-cloud-sdk: fix Darwin build by only stripping local symbols #80554

merged 1 commit into from Feb 21, 2020

Conversation

honkfestival
Copy link
Contributor

Darwin won't strip relocatable symbols, so strip only local symbols from cygrpc.so

From the man page for strip(1):

For dynamic shared libraries, the maximum level of stripping is usually -x (to remove all non-global symbols).

Motivation for this change

Mainly to fix the build on macOS. See also 6ceebc4#commitcomment-37355193

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Please let me know if there's any other testing I should do. I don't have access to a Linux/NixOS machine right now so I couldn't test on that platform, but Hydra should check this, right?

@honkfestival
google-cloud-sdk: fix Darwin build by only stripping local symbols
b0ab07e 
Darwin won't strip relocatable symbols, so strip only local symbols
from cygrpc.so

See also NixOS@6ceebc4#commitcomment-37355193
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 19, 2020
@ofborg ofborg bot requested review from zimbatm and pradyuman February 19, 2020 18:55
@zimbatm zimbatm merged commit 9b8a14b into NixOS:master Feb 21, 2020
zimbatm pushed a commit that referenced this pull request Feb 21, 2020
@honkfestival @zimbatm
google-cloud-sdk: fix Darwin build by only stripping local symbols (#…
d10a014 
…80554)

Darwin won't strip relocatable symbols, so strip only local symbols
from cygrpc.so

See also 6ceebc4#commitcomment-37355193

(cherry picked from commit 9b8a14b)
@zimbatm
Copy link
Member

zimbatm commented Feb 21, 2020

also back-ported to 20.03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm Awaiting requested review from zimbatm

@pradyuman pradyuman Awaiting requested review from pradyuman

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@honkfestival @zimbatm @Janik-Haag