Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitAndTools.gh: fix authentication #80604

Closed
wants to merge 1 commit into from
Closed

gitAndTools.gh: fix authentication #80604

wants to merge 1 commit into from

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 20, 2020 •
edited

Motivation for this change

Fixes an authentication issue with this package vs the official pre-compiled binary that had a different token applied during the build (and is now embedded in the source on master.)

I didn't notice this when submitting the package as I initially tried the pre-complied package and re-used the correctly generated token.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit February 20, 2020 04:55
@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 20, 2020
marsam
marsam reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gh 0.5.6 was released https://github.com/cli/cli/releases/tag/v0.5.6, would you mind updating it?

@zowoq
Copy link
Contributor Author

zowoq commented Feb 20, 2020

Superseded by #80631

@zowoq zowoq closed this Feb 20, 2020
@zowoq zowoq deleted the gh branch February 20, 2020 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam left review comments

@jonringer jonringer jonringer left review comments

@worldofpeace worldofpeace worldofpeace left review comments

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zowoq @marsam @jonringer @worldofpeace