Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlPackages.dum: cleaning #80606

Merged
merged 1 commit into from Feb 27, 2020
Merged

ocamlPackages.dum: cleaning #80606

merged 1 commit into from Feb 27, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Feb 20, 2020

Propagate the easy-format dependency.

Fix build with OCaml ≥ 4.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @alexfmpe maintainer

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: ignoring the user-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
builder for '/nix/store/lg331ix7bmr48fc5fl8jyv40fxw8vjpv-source.drv' failed with exit code 1; last 7 log lines:

  trying https://github.com/mjambon/ocaml4.07.1-dum-1.0.1/archive/v1.0.1.tar.gz
    % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                   Dload  Upload   Total   Spent    Left  Speed
    0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  curl: (22) The requested URL returned error: 404 Not Found
  error: cannot download source from any mirror
cannot build derivation '/nix/store/hgnlg5fspya992ljs0qjqv4136kx0asa-ocaml4.07.1-dum-1.0.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/j66y3lsxilxqc1l0f3r6flx4kv2l7l2w-env.drv': 1 dependencies couldn't be built
[0 built (1 failed), 4 copied (279.9 MiB), 60.0 MiB DL]
error: build of '/nix/store/j66y3lsxilxqc1l0f3r6flx4kv2l7l2w-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80606
1 package failed to build:
ocamlPackages.dum

Propagate the `easy-format` dependency.

Fix build with OCaml ≥ 4.09.
@vbgl
Copy link
Contributor Author

vbgl commented Feb 20, 2020

Thanks. Should be fixed now.

@vbgl
Copy link
Contributor Author

vbgl commented Feb 20, 2020

@GrahamcOfBorg build ocamlPackages.dum

1 similar comment
@jonringer
Copy link
Contributor

@GrahamcOfBorg build ocamlPackages.dum

@vbgl vbgl merged commit 8706ed2 into NixOS:master Feb 27, 2020
@vbgl vbgl deleted the ocaml-dum-clean branch February 27, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants