hy: 0.17.0 -> 0.18.0 #84661
Merged
hy: 0.17.0 -> 0.18.0 #84661
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just noticed that the hy project does not include the |
|
This worked for me. |
|
I don't need to make any more changes unless suggested by reviewers. It works for me, too! I do see other Nix python applications that skip running the tests because they're not there in the PyPI source distribution. I just wasn't sure what the best practice was. |
nixy
approved these changes
Apr 8, 2020
|
I squashed commits and cleaned it up. |
jonringer
reviewed
Apr 14, 2020
langston-barrett
approved these changes
Apr 23, 2020
nixy
approved these changes
Apr 27, 2020
jonringer
reviewed
Apr 28, 2020
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Hy is out of date in nixpkgs and hy has deprecated Python 2 support, so we can update to 0.18.0 and make it a Python 3 application.
Things done
Updated hy package to latest release and to use python3Package.
Setup tests with checkPhase and can run them manually in a nix-shell, but they don't seem to get run properly during nix-build, so set
doCheck = falsesandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)