Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heatseeker: fix finding stty #84662

Merged
merged 1 commit into from May 1, 2020
Merged

heatseeker: fix finding stty #84662

merged 1 commit into from May 1, 2020

Conversation

michaelpj
Copy link
Contributor

Otherwise this crashes at runtime.

I've opened rschmitt/heatseeker#42 upstream.

@bhipple this is the fix from #80539 that's still needed.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@michaelpj
Copy link
Contributor Author

Rats, I pulled out this patch from another commit and missed a bit, sorry!

@michaelpj
heatseeker: fix finding stty
4df9436 
Otherwise this crashes at runtime.

I've opened rschmitt/heatseeker#42 upstream.
@michaelpj
Copy link
Contributor Author

Fixed!

@michaelpj
Copy link
Contributor Author

Gentle ping.

cole-h
cole-h approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Binary works, tested with ls | hs.

[2 built, 2 copied (8.8 MiB), 8.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84662
1 package built:
heatseeker

@michaelpj
Copy link
Contributor Author

ping @bhipple

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/141

@timokau
Copy link
Member

timokau commented May 1, 2020 •
edited

Clear improvement, well-executed with a reference to an upstream issue 👍

Sorry you had to wait so long.

@timokau timokau merged commit bd67369 into NixOS:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michaelpj @nixos-discourse @timokau @cole-h