Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wire-desktop: mac 3.15.3621 -> 3.16.3630 #84491

Merged
merged 1 commit into from Apr 6, 2020
Merged

wire-desktop: mac 3.15.3621 -> 3.16.3630 #84491

merged 1 commit into from Apr 6, 2020

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Apr 6, 2020

Motivation for this change

Here's the bump I said I was expecting in the previous PR : )

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from worldofpeace, Kiwi and arianvp April 6, 2020 16:43
@ofborg ofborg bot requested a review from arianvp April 6, 2020 16:52
This was referenced Apr 6, 2020
Merged
Merged
@ofborg ofborg bot requested a review from arianvp April 6, 2020 17:08
@toonn
Copy link
Contributor Author

toonn commented Apr 6, 2020

@arianvp, sorry for the force push >.<, figured it was a good time to fix the whitespace before backporting. Don't know why ofborg requested a third review though.

@flokli
Copy link
Contributor

flokli commented Apr 6, 2020

@toonn ofborg parses the maintainers attribute and requests maintainers ;-)

@flokli flokli merged commit aea90e8 into NixOS:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arianvp arianvp arianvp approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@Kiwi Kiwi Awaiting requested review from Kiwi

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@toonn @flokli @arianvp