Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.ftfy: Fix dependencies #84528

Merged
merged 1 commit into from Apr 7, 2020
Merged

python3Packages.ftfy: Fix dependencies #84528

merged 1 commit into from Apr 7, 2020

Conversation

lilyball
Copy link
Member

@lilyball lilyball commented Apr 7, 2020

Motivation for this change

Without setuptools the package doesn't work.

$ nix run nixpkgs.python3Packages.ftfy -c ftfy
Traceback (most recent call last):
  File "/nix/store/mvikxjsy91xi29grfkmanvf8il4x9wl5-python3.7-ftfy-5.7/bin/.ftfy-wrapped", line 6, in <module>
    from ftfy.cli import main
  File "/nix/store/mvikxjsy91xi29grfkmanvf8il4x9wl5-python3.7-ftfy-5.7/lib/python3.7/site-packages/ftfy/__init__.py", line 11, in <module>
    from ftfy import fixes
  File "/nix/store/mvikxjsy91xi29grfkmanvf8il4x9wl5-python3.7-ftfy-5.7/lib/python3.7/site-packages/ftfy/fixes.py", line 11, in <module>
    from ftfy.badness import text_cost
  File "/nix/store/mvikxjsy91xi29grfkmanvf8il4x9wl5-python3.7-ftfy-5.7/lib/python3.7/site-packages/ftfy/badness.py", line 9, in <module>
    from ftfy.chardata import chars_to_classes
  File "/nix/store/mvikxjsy91xi29grfkmanvf8il4x9wl5-python3.7-ftfy-5.7/lib/python3.7/site-packages/ftfy/chardata.py", line 12, in <module>
    from pkg_resources import resource_string
ModuleNotFoundError: No module named 'pkg_resources'
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

python3Packages.ftfy: Fix dependencies
24825fe 
`ftfy` depends on `setuptools`. This is not declared by `ftfy` directly,
but without it you'll get a `ModuleNotFoundError`.
@ofborg ofborg bot requested review from aptlin and aborsu April 7, 2020 00:58
jonringer
jonringer approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

failures are broken on target branch

https://github.com/NixOS/nixpkgs/pull/84528
2 packages failed to build:
python37Packages.wordfreq python38Packages.wordfreq

2 packages built:
python37Packages.ftfy python38Packages.ftfy

@jonringer jonringer merged commit 71b1be3 into NixOS:master Apr 7, 2020
@lilyball lilyball deleted the ftfy branch April 7, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@aptlin aptlin Awaiting requested review from aptlin

@aborsu aborsu Awaiting requested review from aborsu

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lilyball @jonringer