Skip to content
This repository has been archived by the owner on Mar 11, 2022. It is now read-only.

sensorfw: Set delay for Hrm and wrist sensor. #7

Closed
wants to merge 1 commit into from

Conversation

MagneFire
Copy link
Member

The heart rate sensor only does a one complete reading when no delay is explicitly set.
The wrist gesture sensor will no longer fire when reactivated if no delay is set.

Use the default delay from the Android code to fix these issues.

It took me a long time to come up with the two lines of code that fixes this issue 馃槅

This issue closes #6 .

@FlorentRevest
Copy link
Member

Awesome job thanks a lot! The time you鈥檝e put into this is really appreciated :)
If you say this is the default value for Android then it shouldn鈥檛 be device specific and you should send a PR that directly implements this in https://github.com/AsteroidOS/sensorfw :)

@MagneFire
Copy link
Member Author

Well, I know that the 200ms is the default used in the ClockworkAmbient binary for sturgeon.
Initially I only looked for a wrist sensor solution. The 200ms appears to solve the issue for the Heart rate sensor too.
Given that I haven't seen any reports to this issue I just assumed that this issue is only relevant for sturgeon.
Are you aware of other platforms having the same/similar issue?

The heart rate sensor only does a one complete reading when no delay is explicitly set.
The wrist gesture sensor will no longer fire when reactivated if no delay is set.

Use the default delay from the Android code to fix these issues.
@MagneFire
Copy link
Member Author

See new PR for https://github.com/AsteroidOS/sensorfw. I guess setting the delay for all platforms shouldn't hurt.

@FlorentRevest
Copy link
Member

Closing as this was merged in sensorfw instead

@MagneFire MagneFire deleted the hrm_wrist_sensor branch April 16, 2020 13:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Heart rate & wrist sensor won't restart
2 participants