Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build against latest Nix #732

Merged
merged 1 commit into from Apr 9, 2020
Merged

Fix build against latest Nix #732

merged 1 commit into from Apr 9, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 7, 2020

See #731.
cc @edolstra

Ma27 added a commit to Ma27/nixpkgs that referenced this pull request Apr 7, 2020
Also removed `pkgs.hydra-flakes` since flake-support has been merged
into master[1]. Because of that, `pkgs.hydra-unstable` is now compiled
against `pkgs.nixFlakes` and currently requires a patch since Hydra's
master doesn't compile[2] atm.

[1] NixOS/hydra#730
[2] NixOS/hydra#732
@kquick
Copy link
Contributor

kquick commented Apr 7, 2020

@edolstra, these are fixes needed because I apparently didn't commit the correct version on the re-sync to latest for PR #703. @Ma27 kindly identified and resolved the problem with this PR. I am not a reviewer/committer so I cannot officially approve this merge, but I apologize for the error and fully endorse acceptance of this PR.

Ma27 added a commit to NixOS/nixpkgs that referenced this pull request Apr 9, 2020
Also removed `pkgs.hydra-flakes` since flake-support has been merged
into master[1]. Because of that, `pkgs.hydra-unstable` is now compiled
against `pkgs.nixFlakes` and currently requires a patch since Hydra's
master doesn't compile[2] atm.

[1] NixOS/hydra#730
[2] NixOS/hydra#732

(cherry picked from commit 0f5c38f)
@grahamc grahamc merged commit 7b70575 into NixOS:master Apr 9, 2020
@Ma27 Ma27 deleted the fix-build branch April 9, 2020 13:19
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
Also removed `pkgs.hydra-flakes` since flake-support has been merged
into master[1]. Because of that, `pkgs.hydra-unstable` is now compiled
against `pkgs.nixFlakes` and currently requires a patch since Hydra's
master doesn't compile[2] atm.

[1] NixOS/hydra#730
[2] NixOS/hydra#732

(cherry picked from commit 0f5c38f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants