Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfs: fix build against 5.6 #84595

Merged
merged 1 commit into from Apr 8, 2020
Merged

zfs: fix build against 5.6 #84595

merged 1 commit into from Apr 8, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 7, 2020

Result of nixpkgs-review pr 84595 1

7 packages marked as broken and skipped:
- bareos
- linuxPackages_hardkernel_4_14.zfs
- linuxPackages_hardkernel_4_14.zfsStable
- linuxPackages_hardkernel_4_14.zfsUnstable
- linuxPackages_hardkernel_latest.zfs
- linuxPackages_hardkernel_latest.zfsStable
- linuxPackages_hardkernel_latest.zfsUnstable
1 package blacklisted:
- tests.nixos-functions.nixosTest-test
16 packages failed to build:
- ceph (ceph-dev)
- ceph-client
- deepin.dde-control-center
- deepin.dde-daemon
- deepin.dde-dock
- deepin.dde-file-manager
- deepin.dde-kwin
- deepin.dde-launcher
- deepin.dde-session-ui
- deepin.deepin-desktop-base
- deepin.deepin-desktop-schemas
- deepin.deepin-wallpapers
- deepin.startdde
- libceph
- linuxPackages_testing_bcachefs.zfs (linuxPackages_testing_bcachefs.zfsStable ,linuxPackages_testing_bcachefs.zfsUnstable)
- sambaFull (samba4Full)
65 packages built:
- collectd
- collectd-data
- deepin.dde-api
- docker-machine-kvm
- docker-machine-kvm2
- easysnap
- gnome3.gnome-boxes
- grub2 (grub2_full)
- grub2_efi
- grub2_pvgrub_image
- grub2_xen
- haskellPackages.libvirt-hs
- haskellPackages.libzfs
- libguestfs
- libguestfs-with-appliance
- libvirt
- libvirt-glib
- libvirt_5_9_0
- libvmi
- linuxPackages-libre.zfs (linuxPackages-libre.zfsStable ,linuxPackages-libre.zfsUnstable)
- linuxPackages.zfs (linuxPackages.zfsStable ,linuxPackages.zfsUnstable ,linuxPackages_5_4.zfs ,linuxPackages_5_4.zfsStable ,linuxPackages_5_4.zfsUnstable)
- linuxPackages_4_14.zfs (linuxPackages_4_14.zfsStable ,linuxPackages_4_14.zfsUnstable)
- linuxPackages_4_19.zfs (linuxPackages_4_19.zfsStable ,linuxPackages_4_19.zfsUnstable)
- linuxPackages_4_4.zfs (linuxPackages_4_4.zfsStable ,linuxPackages_4_4.zfsUnstable)
- linuxPackages_4_9.zfs (linuxPackages_4_9.zfsStable ,linuxPackages_4_9.zfsUnstable)
- linuxPackages_5_5.zfs (linuxPackages_5_5.zfsStable ,linuxPackages_5_5.zfsUnstable)
- linuxPackages_5_6.zfs (linuxPackages_5_6.zfsStable ,linuxPackages_5_6.zfsUnstable ,linuxPackages_latest.zfs ,linuxPackages_latest.zfsStable ,linuxPackages_latest.zfsUnstable)
- linuxPackages_hardened.zfs (linuxPackages_hardened.zfsStable ,linuxPackages_hardened.zfsUnstable)
- linuxPackages_latest-libre.zfs (linuxPackages_latest-libre.zfsStable ,linuxPackages_latest-libre.zfsUnstable)
- linuxPackages_latest_hardened.zfs (linuxPackages_latest_hardened.zfsStable ,linuxPackages_latest_hardened.zfsUnstable)
- linuxPackages_latest_xen_dom0.zfs (linuxPackages_latest_xen_dom0.zfsStable ,linuxPackages_latest_xen_dom0.zfsUnstable)
- linuxPackages_latest_xen_dom0_hardened.zfs (linuxPackages_latest_xen_dom0_hardened.zfsStable ,linuxPackages_latest_xen_dom0_hardened.zfsUnstable)
- linuxPackages_testing_hardened.zfs (linuxPackages_testing_hardened.zfsStable ,linuxPackages_testing_hardened.zfsUnstable)
- linuxPackages_xen_dom0.zfs (linuxPackages_xen_dom0.zfsStable ,linuxPackages_xen_dom0.zfsUnstable)
- linuxPackages_xen_dom0_hardened.zfs (linuxPackages_xen_dom0_hardened.zfsStable ,linuxPackages_xen_dom0_hardened.zfsUnstable)
- minikube
- minishift
- nixops
- nixopsUnstable
- nixops_1_6_1
- os-prober
- perl528Packages.SysVirt
- perl530Packages.SysVirt
- python27Packages.guestfs
- python27Packages.libvirt
- python37Packages.guestfs
- python37Packages.libvirt
- python38Packages.guestfs
- python38Packages.libvirt
- rubyPackages.ruby-libvirt (rubyPackages_2_6.ruby-libvirt)
- rubyPackages_2_5.ruby-libvirt
- rubyPackages_2_7.ruby-libvirt
- sanoid
- terraform-full
- terraform-providers.libvirt
- terraform_0_11-full
- terragrunt
- vagrant
- virt-manager
- virt-manager-qt
- virt-top
- virt-viewer
- virtlyst
- zfs (zfsStable ,zfsUnstable)
- zfstools

@Mic92 Mic92 merged commit b3a9a65 into master Apr 8, 2020
@Mic92 Mic92 deleted the zfs branch April 8, 2020 09:14
@killercup killercup mentioned this pull request Apr 8, 2020
Closed
@veprbl veprbl mentioned this pull request Apr 8, 2020
Closed
10 tasks
@Ma27
Copy link
Member

Ma27 commented Apr 25, 2020

Backported to 20.03 as 346317b since linuxPackages_5_6.zfs is affected here as well.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @Ma27