-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Comparing changes
Open a pull request
base repository: NixOS/nix
base: f32a9b354dd9
head repository: NixOS/nix
compare: 55cefd41d633
- 18 commits
- 5 files changed
- 4 contributors
Commits on Mar 29, 2020
-
Add fetchSubmodules to builtins.fetchGit
There are some downsides to this features: - Submodules are not cached (unlike the root repo), - Full checkouts are created in a temporary directory.
Configuration menu - View commit details
-
Copy full SHA for f58604a - Browse repository at this point
Copy the full SHA f58604aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c2a24c2 - Browse repository at this point
Copy the full SHA c2a24c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea861be - Browse repository at this point
Copy the full SHA ea861beView commit details -
Add git submodule fixes from @bjornfor
This fixes fetching repositories with no submodules and also cleans up .git files in checkouts.
Configuration menu - View commit details
-
Copy full SHA for c8d33de - Browse repository at this point
Copy the full SHA c8d33deView commit details -
Configuration menu - View commit details
-
Copy full SHA for c846abb - Browse repository at this point
Copy the full SHA c846abbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 435366e - Browse repository at this point
Copy the full SHA 435366eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c00a95 - Browse repository at this point
Copy the full SHA 6c00a95View commit details -
Some platforms seem to still require linking with stdc++fs to enable STL std::filesystem support.
Configuration menu - View commit details
-
Copy full SHA for cc4fe97 - Browse repository at this point
Copy the full SHA cc4fe97View commit details -
fetchGit: fix "fatal: couldn't find remote ref refs/heads/master" iss…
…ue with submodules
Configuration menu - View commit details
-
Copy full SHA for 002a3a9 - Browse repository at this point
Copy the full SHA 002a3a9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 587e259 - Browse repository at this point
Copy the full SHA 587e259View commit details -
fetchGit: fix submodule output attribute
Before this change it would be false for all evaluations but the first. Now it follows the input argument (as it should).
Configuration menu - View commit details
-
Copy full SHA for 6864ad7 - Browse repository at this point
Copy the full SHA 6864ad7View commit details -
fetchGit: add submodules attribute to the .link file
The .link file is used as a lock, so I think we should put the "submodule" attribute in there since turning on submodules creates a new .link file path.
Configuration menu - View commit details
-
Copy full SHA for 369fffd - Browse repository at this point
Copy the full SHA 369fffdView commit details -
Configuration menu - View commit details
-
Copy full SHA for be84049 - Browse repository at this point
Copy the full SHA be84049View commit details -
fetchGit: checkout rev instead of latest ref
Major bugfix for the submodules = true code path. TODO: Add tests.
Configuration menu - View commit details
-
Copy full SHA for b306b70 - Browse repository at this point
Copy the full SHA b306b70View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc522d0 - Browse repository at this point
Copy the full SHA cc522d0View commit details -
fetchGit: fix submodule corner case by fetching all refs from cacheDir
Due to fetchGit not checking if rev is an ancestor of ref (there is even a FIXME comment about it in the code), the cache repo might not have the ref even though it has the rev. This doesn't matter when submodule = false, but the submodule = true code blows up because it tries to fetch the (missing) ref from the cache repo. Fix this in the simplest way possible: fetch all refs from the local cache repo when submodules = true. TODO: Add tests.
Configuration menu - View commit details
-
Copy full SHA for f686efe - Browse repository at this point
Copy the full SHA f686efeView commit details -
fetchGit: don't use std::filesystem to filter git repos
Using std::filesystem means also having to link with -lstdc++fs on some platforms and it's hard to discover for what platforms this is needed. As all the functionality is already implemented as utilities, use those instead.
Configuration menu - View commit details
-
Copy full SHA for 40c023e - Browse repository at this point
Copy the full SHA 40c023eView commit details
Commits on Apr 7, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 55cefd4 - Browse repository at this point
Copy the full SHA 55cefd4View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff f32a9b354dd9...55cefd41d633