Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.acpi-call: switch to nix-community fork #84597

Merged
merged 1 commit into from Apr 8, 2020
Merged

linuxPackages.acpi-call: switch to nix-community fork #84597

merged 1 commit into from Apr 8, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 7, 2020

This fixes also build against linux 5.6
We also took the opportunity to cleanup the build.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from 7c6f434c April 7, 2020 12:14
@Mic92
Copy link
Member Author

Mic92 commented Apr 7, 2020

Result of nixpkgs-review pr 84597 1

1 package failed to build:
- linuxPackages_testing_bcachefs.acpi_call
16 packages built:
- linuxPackages-libre.acpi_call
- linuxPackages.acpi_call
- linuxPackages_4_14.acpi_call
- linuxPackages_4_19.acpi_call
- linuxPackages_4_4.acpi_call
- linuxPackages_4_9.acpi_call
- linuxPackages_5_5.acpi_call
- linuxPackages_5_6.acpi_call
- linuxPackages_hardened.acpi_call
- linuxPackages_latest-libre.acpi_call
- linuxPackages_latest_hardened.acpi_call
- linuxPackages_latest_xen_dom0.acpi_call
- linuxPackages_latest_xen_dom0_hardened.acpi_call
- linuxPackages_testing_hardened.acpi_call
- linuxPackages_xen_dom0.acpi_call
- linuxPackages_xen_dom0_hardened.acpi_call

@ofborg ofborg bot requested a review from 7c6f434c April 8, 2020 13:47
@Mic92
linuxPackages.acpi-call: switch to nix-community fork
1ae03c9 
This fixes also build against linux 5.6
We also took the opportunity to cleanup the build.
LEXUGE
LEXUGE approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@LEXUGE LEXUGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks better.
LGTM

@LEXUGE LEXUGE mentioned this pull request Apr 8, 2020
Closed
@Mic92 Mic92 merged commit fe8875a into master Apr 8, 2020
@Mic92 Mic92 deleted the acpi-call branch April 8, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LEXUGE LEXUGE LEXUGE approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @7c6f434c @LEXUGE