Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sysdig: fix linux 5.6 build #84596

Closed
wants to merge 1 commit into from
Closed

sysdig: fix linux 5.6 build #84596

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 7, 2020

Have not yet tested all old kernel version.
Patch was also sent upstream in draios/sysdig#1614

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 7, 2020

Result of nixpkgs-review pr 84596 1

3 packages marked as broken and skipped:
- linuxPackages_4_4.sysdig
- linuxPackages_4_9.sysdig
- linuxPackages_hardkernel_4_14.sysdig
2 packages failed to build:
- linuxPackages_4_14.sysdig
- linuxPackages_testing_bcachefs.sysdig
14 packages built:
- linuxPackages-libre.sysdig
- linuxPackages.sysdig
- linuxPackages_4_19.sysdig
- linuxPackages_5_5.sysdig
- linuxPackages_5_6.sysdig
- linuxPackages_hardened.sysdig
- linuxPackages_latest-libre.sysdig
- linuxPackages_latest_hardened.sysdig
- linuxPackages_latest_xen_dom0.sysdig
- linuxPackages_latest_xen_dom0_hardened.sysdig
- linuxPackages_testing_hardened.sysdig
- linuxPackages_xen_dom0.sysdig
- linuxPackages_xen_dom0_hardened.sysdig
- sysdig

@ofborg ofborg bot requested a review from 7c6f434c April 7, 2020 13:19
@Mic92
Copy link
Member Author

Mic92 commented Apr 7, 2020

linuxPackages_4_14.sysdig did not fail before.

@Mic92
Copy link
Member Author

Mic92 commented May 5, 2020

There has been a new upstream release. Will make a new pr.

@Mic92 Mic92 closed this May 5, 2020
@Mic92 Mic92 deleted the sysdig branch May 5, 2020 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Mic92