Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rs: init at 20200313 #84546

Merged
merged 1 commit into from Apr 14, 2020
Merged

rs: init at 20200313 #84546

merged 1 commit into from Apr 14, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Apr 7, 2020 •
edited

Motivation for this change

rs is a small utility from BSD world. It formats the input as a table.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cole-h
Copy link
Member

cole-h commented Apr 7, 2020

And also, the commit should be rs: init at 20200313 to follow our conventions, not start at.

@AndersonTorres AndersonTorres changed the title rs: start at 20200313 rs: init at 20200313 Apr 7, 2020
@AndersonTorres AndersonTorres merged commit 143e5f6 into NixOS:master Apr 14, 2020
@AndersonTorres AndersonTorres deleted the create-rs branch April 14, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AndersonTorres @cole-h