Rename download to filetransfer #3476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase this? |
knl
force-pushed
the
rename-download-to-filetransfer
branch
from
df8e1bb
to
1e88244
Compare
@edolstra Done |
|
Once again :) |
knl
force-pushed
the
rename-download-to-filetransfer
branch
from
1e88244
to
7867685
Compare
|
@domenkozar @edolstra Done, again :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change renames all instances of Download to FileTransfer. I initially was taken by surprise that
getDownloader->download()would also do uploads, depending on whetherDownloadstruct has data field or not. Thus, in order to ease the cognitive burden of the future readers of the code, I went in and did a rename.In addition, this change introduces a new method called
upload, which is exactly the same asdownload, which in turns just enqueues the request and synchronously waits. This is to make it more readable at the call site what is happening.All the changes will be squashed into a single one prior to (hopefully) approval and merging.