Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/lib/test-driver: Fix require_unit_state hardcoded formatting #84517

Merged
merged 1 commit into from Apr 6, 2020
Merged

nixos/lib/test-driver: Fix require_unit_state hardcoded formatting #84517

merged 1 commit into from Apr 6, 2020

Conversation

infinisil
Copy link
Member

Motivation for this change

Noticed this mistake when using this function

Ping @tfc

Things done
  • Tested it with my own test to make sure it works

@infinisil infinisil requested a review from tfc as a code owner April 6, 2020 21:58
@Ma27 Ma27 merged commit 6541f75 into NixOS:master Apr 6, 2020
@Ma27
Copy link
Member

Ma27 commented Apr 6, 2020

Thanks! Also backported as 2216211 to 20.03.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Apr 6, 2020
@infinisil infinisil deleted the fix-test-driver-formatting branch April 7, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@tfc tfc Awaiting requested review from tfc tfc is a code owner

Assignees
No one assigned
Labels
6.topic: nixos 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@infinisil @Ma27