Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.RPM2: init at 1.4 #84559

Merged
merged 1 commit into from Sep 14, 2020
Merged

Conversation

invokesus
Copy link
Contributor

@invokesus invokesus commented Apr 7, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@invokesus
Copy link
Contributor Author

Fixed. :)

Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@stigtsp stigtsp requested a review from aanderse July 6, 2020 17:52
@aanderse
Copy link
Member

aanderse commented Jul 6, 2020

@GrahamcOfBorg build perlPackages.RPM2 perldevelPackages.RPM2

@aanderse
Copy link
Member

@invokesus please address build failure.

@invokesus
Copy link
Contributor Author

@aanderse Added meta.platforms to restrict it to only Linux.

@stigtsp
Copy link
Member

stigtsp commented Sep 14, 2020

@GrahamcOfBorg build perlPackages.RPM2 perldevelPackages.RPM2

@stigtsp stigtsp merged commit 0d82843 into NixOS:master Sep 14, 2020
@stigtsp
Copy link
Member

stigtsp commented Sep 14, 2020

@invokesus Thx for the contribution.

@invokesus invokesus deleted the contrib/perl-rpm2 branch September 14, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants