Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 84867e44bfb0
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: fd85e86232e3
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on Dec 7, 2019

  1. perlPackages.XMLParser: Work around cross-compilation regression

    Since 2.44_01, the behaviour for `check_lib` in their `Makefile.PL` has
    been "fixed" to fail when the `assert_lib` function fails to build the
    test.
    
     * cpan-authors/XML-Parser@2bc1e90
    
    Now, this wouldn't be so bad, since it's good to actually test what
    stuff is being compiled against.
    
    Except that *something* is wonky with the cross-compilation build-time
    Perl.
    
    ```
    Undefined subroutine &File::Temp::mktemp called at inc/Devel/CheckLib.pm line 236.
    ```
    
    As far as I know, this is a built-in function from Perl.
    
     * https://perldoc.perl.org/File/Temp.html
    
    Though, something *else* is wrong with `Checklib.pm`. Side-stepping the
    issue by (eww) shelling out to `mktemp`, we get these errors:
    
    ```
    
    /nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-armv7l-unknown-linux-gnueabihf-binutils-2.31.1/bin/armv7l-unknown-linux-gnueabihf-ld: assertlib_src1_0.553056903257133: file not recognized: file truncated
    collect2: error: ld returned 1 exit status
     -I/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-expat-2.2.8-armv7l-unknown-linux-gnueabihf-dev/include -L/nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-expat-2.2.8-armv7l-unknown-linux-gnueabihf/lib -lexpat
    /nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-armv7l-unknown-linux-gnueabihf-binutils-2.31.1/bin/armv7l-unknown-linux-gnueabihf-ld: assertlib_src2_0.262169388446154: file not recognized: file truncated
    collect2: error: ld returned 1 exit status
    Can't link/include C library 'expat.h', 'expat', aborting.
    ```
    
    Meanwhile, the actual build, while building the library, seemingly has
    no issues building using those paths. `¯\_(ツ)_/¯`
    samueldr committed Dec 7, 2019
    Copy the full SHA
    706247f View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Merge pull request #75132 from samueldr/fix/cross/perl-xmlparser

    perlPackages.XMLParser: Work around cross-compilation regression
    Ericson2314 committed Apr 7, 2020
    Copy the full SHA
    fd85e86 View commit details
    Browse the repository at this point in the history