Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nano: 4.9.1 -> 4.9.2 #84606

Merged
merged 1 commit into from May 26, 2020
Merged

nano: 4.9.1 -> 4.9.2 #84606

merged 1 commit into from May 26, 2020

Conversation

lsix
Copy link
Member

@lsix lsix commented Apr 7, 2020 •
edited

See https://lists.gnu.org/archive/html/info-gnu/2020-04/msg00001.html

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from joachifm April 7, 2020 13:49
Emantor
Emantor approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • built on NixOS unstable
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/phoenix/.cache/nixpkgs-review/pr-84606/build.nix
[14 built, 67 copied (89.7 MiB), 19.7 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84606
2 package marked as broken and skipped:
reposurgeon rssh

2 package blacklisted:
tests.nixos-functions.nixos-test tests.nixos-functions.nixosTest-test

12 package built:
cabal2nix crip cvs cvs2svn cvs_fast_export cvsps cvsq dep2nix nano nix-prefetch-cvs nix-prefetch-scripts nix-update-source
  • tested nano, the editor works. I did not test the other binaries/scripts and wonder why nano triggered a rebuild there.

@dasj19
Copy link
Contributor

dasj19 commented May 12, 2020

Tested with on nixos unstable with:
nix run -I nixpkgs=channel:nixos-unstable nixpkgs.nixpkgs-review -c nixpkgs-review pr 84606 and works like a charm ++ for including in unstable

I don't know either a way to check all the built functionality but the editor works as it should

@lsix lsix merged commit 9f11766 into NixOS:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor approved these changes

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lsix @dasj19 @Emantor