Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update authoring.rst after a few more implementations. #1277

Merged
merged 8 commits into from Apr 7, 2020

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Apr 7, 2020

No description provided.

@cole-h
Copy link
Member

cole-h commented Apr 7, 2020

Might be worth it to also highlight the other Nix blocks, like in the On with Poetry section.

Comment on lines 33 to 35
project. This is instead of a ``setup.py``, and using both may cause
confusing build errors. Only use a ``pyproject.toml``:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This is instead of a just sounds weird to me.

We do not use setup.py, and trying to use both a setup.py and pyproject.toml may cause confusing build errors.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixup'd!

@grahamc grahamc merged commit ad078df into NixOS:master Apr 7, 2020
@grahamc grahamc deleted the docs-update branch April 7, 2020 21:46
@grahamc grahamc added this to the 2.0 milestone Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants