Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/ofborg
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 284a7bfeaadc
Choose a base ref
...
head repository: NixOS/ofborg
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 83d748169c2d
Choose a head ref
  • 3 commits
  • 2 files changed
  • 2 contributors

Commits on Apr 7, 2020

  1. tasks/eval/nixpkgs: don't request review from PR author 

    GitHub doesn't let us, so we silently skip them.
    @cole-h
    cole-h committed Apr 7, 2020
    Copy the full SHA
    5fd48be View commit details

  2. tasks/build: don't use \n to split log line 

    Otherwise, we have one line that has the log prefix, and one line
immediately following that doesn't.
    @cole-h
    cole-h committed Apr 7, 2020
    Copy the full SHA
    5de114c View commit details

  3. Merge pull request #457 from cole-h/logging 

    More logging
    @grahamc
    grahamc authored Apr 7, 2020
    Copy the full SHA
    83d7481 View commit details
Showing with 12 additions and 1 deletion.
  1. +2 −1 ofborg/src/tasks/build.rs
  2. +10 −0 ofborg/src/tasks/eval/nixpkgs.rs
3 changes: 2 additions & 1 deletion ofborg/src/tasks/build.rs
View file
Original file line number Diff line number Diff line change
@@ -373,7 +373,8 @@ impl notifyworker::SimpleNotifyWorker for BuildWorker {
};

info!("ok built ({:?}), building", status);
info!("Lines:\n-----8<-----");
info!("Lines:");
info!("-----8<-----");
actions
.log_snippet()
.iter()
10 changes: 10 additions & 0 deletions ofborg/src/tasks/eval/nixpkgs.rs
View file
Original file line number Diff line number Diff line change
@@ -566,8 +566,18 @@ impl<'a> EvaluationStrategy for NixpkgsStrategy<'a> {
}

fn request_reviews(maint: &maintainers::ImpactedMaintainers, pull: &hubcaps::pulls::PullRequest) {
let pull_meta = pull.get();

if maint.maintainers().len() < 10 {
for maintainer in maint.maintainers() {
if let Ok(meta) = &pull_meta {
// GitHub doesn't let us request a review from the PR author, so
// we silently skip them.
if meta.user.login.to_ascii_lowercase() == maintainer.to_ascii_lowercase() {
continue;
}
}

if let Err(e) =
pull.review_requests()
.create(&hubcaps::review_requests::ReviewRequestOptions {