Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hactool: init at 1.3.3 #84494

Merged
merged 1 commit into from May 3, 2020
Merged

hactool: init at 1.3.3 #84494

merged 1 commit into from May 3, 2020

Conversation

IvarWithoutBones
Copy link
Member

Motivation for this change

Adds hactool

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Emantor
Emantor approved these changes Apr 6, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • checked license
  • build binaries
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/phoenix/.cache/nixpkgs-review/pr-84494/build.nix
[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84494
1 package built:
hactool
  • program works in so far that it outputs the help section

Emantor
Emantor suggested changes Apr 6, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message is missing an at: hactool: init at 1.3.2

@IvarWithoutBones
Copy link
Member Author

Commit message is missing an at: hactool: init at 1.3.2

My bad, fixed.

@IvarWithoutBones IvarWithoutBones changed the title hactool: init 1.3.2 hactool: init at 1.3.2 Apr 6, 2020
@IvarWithoutBones IvarWithoutBones changed the title hactool: init at 1.3.2 hactool: init at 1.3.3 Apr 25, 2020
@IvarWithoutBones
Copy link
Member Author

Apologies for the messing around, thought that'd compile.

Anything blocking this from getting merged?

jonringer
jonringer reviewed May 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

https://github.com/NixOS/nixpkgs/pull/84494
1 package built:
hactool

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 84494 1

1 package built:
- hactool

@jonringer jonringer merged commit 35639c6 into NixOS:master May 3, 2020
@IvarWithoutBones IvarWithoutBones deleted the hactool branch May 3, 2020 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emantor Emantor Emantor approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvarWithoutBones @Emantor @jonringer