Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

treewide: Fix types of stripDebugList attrs (and fix doc) #84551

Merged
merged 2 commits into from Apr 14, 2020
Merged

treewide: Fix types of stripDebugList attrs (and fix doc) #84551

merged 2 commits into from Apr 14, 2020

Conversation

gnprice
Copy link
Contributor

@gnprice gnprice commented Apr 7, 2020 •
edited

Motivation for this change

The documentation says this should be a list, and it already is in about half the expressions that set it.

The difference doesn't matter at present, because the elements of these are all space-free literals. But it will in a future with __structuredAttrs .

(The similar attr stripAllList has no users in the nixpkgs tree, so there's nothing to do to fix any of those up.)

Also fix the default value mentioned in the doc, as I noticed when grepping that it was out of date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    • (This finds nothing to rebuild, as intended.)
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@gnprice
treewide: Fix up stripDebugList attrs to be lists.
7547cf9 
The documentation says this should be a list, and it already is in
about half the expressions that set it.

The difference doesn't matter at present, because these values are all
space-free literals.  But it will in a future with __structuredAttrs .

(The similar attr stripAllList has no users in the nixpkgs tree, so
there's nothing to do to fix any of those up.)
@gnprice
doc/stdenv: Update default for stripDebugList.
53d61f9 
This has changed a few times from 2008 to 2012: cdc74e1, d9213df,
and 095db9f.
@worldofpeace worldofpeace requested a review from Ma27 April 14, 2020 12:28
@Ma27 Ma27 merged commit 401e07d into NixOS:master Apr 14, 2020
@Ma27 Ma27 mentioned this pull request Apr 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

Assignees
No one assigned
Labels
8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gnprice @Ma27