Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] haskellPackages.pandoc-crossref: downgrade to latest working #84645

Merged
merged 1 commit into from Apr 8, 2020
Merged

[20.03] haskellPackages.pandoc-crossref: downgrade to latest working #84645

merged 1 commit into from Apr 8, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Apr 7, 2020

Motivation for this change

I'm moving #80556 to target 20.03 since pandoc-crossref was fixed in master and 20.03 is not getting a haskell update, it seems.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@cdepillabout
Copy link
Member

Looks good to me, thanks!

@cdepillabout cdepillabout merged commit 540d671 into NixOS:release-20.03 Apr 8, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Apr 8, 2020

Thank you.

@rnhmjoj rnhmjoj deleted the pandoc-crossref-20.03 branch June 19, 2020 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

@basvandijk basvandijk Awaiting requested review from basvandijk

@infinisil infinisil Awaiting requested review from infinisil infinisil is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rnhmjoj @cdepillabout