Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.pam: init at 1.8.4 #84544

Merged
merged 1 commit into from Apr 7, 2020
Merged

Conversation

mkg20001
Copy link
Member

@mkg20001 mkg20001 commented Apr 7, 2020

Motivation for this change

Needed for cinnamon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/development/python-modules/pam/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM after @cole-h 's suggestions

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM. Builds fine.

[5 built, 33 copied (89.0 MiB), 16.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84544
25 package marked as broken and skipped:
gdata-sharp iterm2 linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 linuxPackages_hardkernel_4_14.nvidiabl linuxPackages_hardkernel_4_14.prl-tools linuxPackages_hardkernel_4_14.rtl8821ce nix-linter octave-jit octoprint php74Extensions.couchbase php74Extensions.pthreads python27Packages.caffe python27Packages.habanero python27Packages.handout python27Packages.hass-nabucasa python37Packages.pyblock python38Packages.pyblock synfigstudio

3 package built:
python27Packages.pam python37Packages.pam python38Packages.pam

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/84544
25 package marked as broken and skipped:
gdata-sharp iterm2 linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 linuxPackages_hardkernel_4_14.nvidiabl linuxPackages_hardkernel_4_14.prl-tools linuxPackages_hardkernel_4_14.rtl8821ce nix-linter octave-jit octoprint php74Extensions.couchbase php74Extensions.pthreads python27Packages.caffe python27Packages.habanero python27Packages.handout python27Packages.hass-nabucasa python37Packages.pyblock python38Packages.pyblock synfigstudio

3 package built:
python27Packages.pam python37Packages.pam python38Packages.pam

@jonringer jonringer merged commit 4e71d7e into NixOS:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants