Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] plasma5: 5.17.5 -> 5.18.5 #84542

Merged
merged 16 commits into from Sep 2, 2020
Merged

[WIP] plasma5: 5.17.5 -> 5.18.5 #84542

merged 16 commits into from Sep 2, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 7, 2020 •
edited by ttuegel

Motivation for this change
Todo list:

  • port patches / fix broken behaviour in these packages

    • plasma-workspace
      • 0001-startkde.patch
      • 0002-absolute-wallpaper-install-dir.patch
    • kde-gtk-config
      • follow-symlinks.patch
      • gsettings.patch
    • sddm plasma theme
      • fix background image

  • fix broken packages:

    • deepin.dde-kwin
    • deepin.startdde
    • kdecoration-viewer
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost ghost requested review from FRidh, jonringer and ttuegel as code owners April 7, 2020 03:04
@ofborg ofborg bot requested review from lovek323 and svanderburg April 7, 2020 03:11
@FRidh FRidh added this to WIP in Staging via automation Apr 7, 2020
@peterhoeg peterhoeg mentioned this pull request Apr 7, 2020
Closed
10 tasks
@ghost
Copy link
Author

ghost commented Apr 7, 2020

nix-review output:

https://github.com/NixOS/nixpkgs/pull/84542
4 package marked as broken and skipped:
gazeboSimulator.sdformat gazeboSimulator.sdformat3 kst linuxPackages_hardkernel_4_14.systemtap

3 package failed to build:
deepin.dde-kwin deepin.startdde kdecoration-viewer

54 package built:
bluedevil breeze-grub breeze-gtk breeze-plymouth breeze-qt5 digikam discover kactivitymanagerd kde-cli-tools kde-gtk-config kde2-decoration kdeApplications.kdenlive kdeApplications.spectacle kdeplasma-addons kdev-php kdev-python kdevelop kdevelop-unwrapped kgamma5 kinfocenter kmenuedit krohnkite kscreen kscreenlocker ksshaskpass ksysguard kwallet-pam kwayland-integration kwin kwin-tiling kwrited plasma5.kdecoration plasma5.khotkeys plasma5.libkscreen plasma5.libksysguard lxqt.lxqt-config milou oxygen plasma-applet-volumewin7mixer plasma-browser-integration plasma-desktop plasma-integration plasma-nm plasma-pa plasma-vault plasma-workspace plasma-workspace-wallpapers plasma5.polkit-kde-agent plasma5.powerdevil plasma5.sddm-kcm plasma5.systemsettings plasma5.user-manager plasma5.xdg-desktop-portal-kde wacomtablet

@ghost ghost changed the title WIP: plasma 5.18 [WIP] plasma 5.18 Apr 7, 2020
@ghost ghost changed the title [WIP] plasma 5.18 [WIP] plasma5: 5.17.5 -> 5.18.4 Apr 7, 2020
@ghost ghost mentioned this pull request Apr 7, 2020
Merged
37 tasks
@ghost
Copy link
Author

ghost commented Apr 9, 2020

It actually works surprisingly well. The builtin wallpapers are now detected again and the system settings seem fine too.

image

@peterhoeg
Copy link
Member

Is this getting good to go by chance?

@ghost
Copy link
Author

ghost commented Apr 22, 2020

The gtk settings and deepin packages are broken (due to kwin update). I have spent some time on both but didn't find any easy fixes. If you want to bring this closer to being merged, feel free to take a look at those problems. I can not tell how much time I will be able to spend on this in the next days.

@romildo
Copy link
Contributor

romildo commented Apr 23, 2020

The gtk settings and deepin packages are broken (due to kwin update).

The deepin packages have stagnated on upstream. For almost an year they have not been updated. Deepin Linux is working privately on a new version of their Linux distribution with substantial changes. For this reason the packaging of the Deepin Desktop Environment is dormant on nixpkgs as well, waiting new releases from upstream.

For now I think you can mark both deepin.dde-kwin and deepin.startdde (which depends on deepin.dde-kwin) as broken.

cc @worldofpeace

@zowoq
Copy link
Contributor

zowoq commented Aug 22, 2020

@ofborg eval

@ttuegel
Copy link
Member

ttuegel commented Aug 28, 2020

I am investigating the GTK theme issue now. My first guess is that it is due to the missing dependency on xsettingsd.

@ttuegel
Copy link
Member

ttuegel commented Aug 31, 2020 •
edited

I am investigating the GTK theme issue now. My first guess is that it is due to the missing dependency on xsettingsd.

Actually, it has nothing to do with kde-gtk-config at all. It seems that kded is not running, or at least systemsettings cannot connect to it. I discovered this when I tried to configure Background Services.

EDIT: I have lots of messages like this in dmesg:

traps: .kded5-wrapped[4407] trap int3 ip:7fe761ac13f5 sp:7fff84dabe00 error:0 in libglib-2.0.so.0.6400.4[7fe761a87000+81000]

So I guess kded is segfaulting?

@ttuegel
Copy link
Member

ttuegel commented Aug 31, 2020

Apparently I already fixed this? #40447
But now the patch must move. 🙄

@FRidh
Copy link
Member

FRidh commented Aug 31, 2020 •
edited

deepin was removed in #96610, please rebase.

@ttuegel
Copy link
Member

ttuegel commented Aug 31, 2020

I fixed kde-gtk-config, but I'm still tracking down some missing dependencies.

@ofborg ofborg bot requested review from ttuegel and removed request for lovek323 September 1, 2020 11:20
@ttuegel
Copy link
Member

ttuegel commented Sep 1, 2020

We are still affected by #96055, but I don't see that as a reason to block merging as soon as the check pass again!

@ttuegel ttuegel merged commit 1c47df2 into NixOS:master Sep 2, 2020
Staging automation moved this from WIP to Done Sep 2, 2020
@ttuegel
Copy link
Member

ttuegel commented Sep 2, 2020

Thanks everyone who helped this happen, especially @petabyteboy ! 🎉

This was referenced Sep 5, 2020
Closed
Closed
@ajs124 ajs124 mentioned this pull request Oct 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@svanderburg svanderburg Awaiting requested review from svanderburg

@romildo romildo Awaiting requested review from romildo

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@DIzFer DIzFer Awaiting requested review from DIzFer

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
2.status: work-in-progress 6.topic: qt/kde 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
Staging
  
Done
Milestone
20.09
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@peterhoeg @romildo @worldofpeace @corpix @zowoq @ttuegel @FRidh @DIzFer @cole-h