Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stella: 4.1.1 -> 6.1.1 #84611

Merged
merged 3 commits into from Apr 9, 2020
Merged

stella: 4.1.1 -> 6.1.1 #84611

merged 3 commits into from Apr 9, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Apr 7, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Emantor
Emantor approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • build package
$ nix build --no-link --keep-going --option build-use-sandbox relaxed -f /home/phoenix/.cache/nixpkgs-review/pr-84611/build.nix
[3 built, 1 copied (1.6 MiB), 0.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/84611
1 package built:
stella
  • output binary works and lets me play space invaders 👾👾👾

I think this derivation would vastly profit from using enableParallelBuilding = true;, since the compilation takes quite long on a single core. If the stella build system is able to cope with it, you should consider this option.

@AndersonTorres
Copy link
Member Author

@Emantor done

@AndersonTorres @OPNA2608
Update pkgs/misc/emulators/stella/default.nix
52a2005 
Co-Authored-By: Christoph Neidahl <christoph.neidahl@gmail.com>
Emantor
Emantor approved these changes Apr 9, 2020
View reviewed changes
Copy link
Member

@Emantor Emantor left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With enableParallelBuildingit now works correctly and builds much faster.

@aanderse aanderse merged commit 972748b into NixOS:master Apr 9, 2020
@AndersonTorres AndersonTorres deleted the update-stella branch November 30, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OPNA2608 OPNA2608 OPNA2608 left review comments

@Emantor Emantor Emantor approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndersonTorres @Emantor @OPNA2608 @aanderse