Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CryptRandom and its dependencies #84558

Merged
merged 4 commits into from Jul 7, 2020
Merged

perlPackages.CryptRandom and its dependencies #84558

merged 4 commits into from Jul 7, 2020

Conversation

invokesus
Copy link
Contributor

@invokesus invokesus commented Apr 7, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@invokesus
Copy link
Contributor Author

I wasn't sure whether to add meta.maintainers or not, since most of perlPackages doesn't have it. Let me know if I should add that. 🙂

@invokesus
Copy link
Contributor Author

Thanks for reviewing! Amended and force-pushed.

stigtsp
stigtsp approved these changes Jul 7, 2020
View reviewed changes
Copy link
Member

@stigtsp stigtsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Result of nixpkgs-review pr 84558 1

8 packages built:
- perl528Packages.ClassLoader
- perl528Packages.CryptRandom
- perl528Packages.MathPari
- perl528Packages.StatisticsChiSquare
- perl530Packages.ClassLoader
- perl530Packages.CryptRandom
- perl530Packages.MathPari
- perl530Packages.StatisticsChiSquare

@stigtsp stigtsp requested a review from aanderse July 7, 2020 00:44
@aanderse
Copy link
Member

aanderse commented Jul 7, 2020

@GrahamcOfBorg build perlPackages.ClassLoader perlPackages.CryptRandom perlPackages.MathPari perlPackages.StatisticsChiSquare
@GrahamcOfBorg build perldevelPackages.ClassLoader perldevelPackages.CryptRandom perldevelPackages.MathPari perldevelPackages.StatisticsChiSquare

@aanderse aanderse merged commit d22d7a9 into NixOS:master Jul 7, 2020
@invokesus invokesus deleted the contrib/perl-cryptrandom branch September 14, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stigtsp stigtsp stigtsp approved these changes

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@invokesus @aanderse @stigtsp