Skip to content

treewide: use runtimeShell in nixos/ #84556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 8, 2020
Merged

treewide: use runtimeShell in nixos/ #84556

merged 1 commit into from
Apr 8, 2020
+22 −22

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 7, 2020

This is needed for cross-compilation.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Mic92
treewide: use runtimeShell in nixos/

Verified

This commit was signed with the committer’s verified signature.
NeQuissimus Tim Steinbach
GPG key ID: 472BFCCA96BD0EDA
Verified
Learn about vigilant mode
cf3328e 
This is needed for cross-compilation.
@Mic92 Mic92 requested a review from matthewbauer April 7, 2020 06:28
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Apr 7, 2020
@peterhoeg
Copy link
Member

How about using writeShellScript instead? That should already give us runtimeShell for free.

@grahamc grahamc removed the ofborg-internal-error Ofborg encountered an error label Apr 7, 2020
@Mic92
Copy link
Member Author

Mic92 commented Apr 8, 2020

Could be used for all writeScript cases but not writeScriptBin.

@peterhoeg
Copy link
Member

I've made a mental note to check out the difference.

And in that case, this looks very undramatic.

@peterhoeg
Copy link
Member

@GrahamcOfBorg eval

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 8, 2020
@Mic92 Mic92 merged commit 0b5d6d9 into NixOS:master Apr 8, 2020
@Mic92 Mic92 deleted the runtime-shell branch April 8, 2020 15:34
ajs124 pushed a commit that referenced this pull request May 21, 2021
@Yarny0
nixos/hylafax: use runtimeShell where possible
4415846 
According to
#84556
this effort helps with cross-compilation.

This commit also renames a substituted variable `hylafax`
to `hylafaxplus` to permit substitution with `inherit`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @peterhoeg @grahamc