Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build against nix master #731

Closed
wants to merge 1 commit into from
Closed

Fix build against nix master #731

wants to merge 1 commit into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Apr 6, 2020

The current Hydra master was broken when building against
pkgs.nixUnstable from NixOS 20.03 (5e7ccdc9).

Please note that the nix-shell breaks due to the switch to 20.03 with
the following error:

bash: src: unbound variable
build time elapsed:  0m2.172s 0m0.261s 0m0.089s 0m0.026s
bash: succeedOnFailure: unbound variable

nix-build release.nix -A build is building.
cc @edolstra @kquick

@Ma27
Fix build against nix master
eb3468a 
The current Hydra master was broken when building against
`pkgs.nixUnstbale` from NixOS 20.03 (5e7ccdc9).

Please note that the nix-shell breaks due to the switch to 20.03 with
the following error:

    bash: src: unbound variable
    build time elapsed:  0m2.172s 0m0.261s 0m0.089s 0m0.026s
    bash: succeedOnFailure: unbound variable
@kquick
Copy link
Contributor

kquick commented Apr 6, 2020

Thanks for catching those @Ma27 ; I must have missed committing those fixes as part of re-updating the PR.

@Mic92
Copy link
Member

Mic92 commented Apr 7, 2020

Also part of this PR against nixpkgs: NixOS/nixpkgs#84501

@edolstra
Copy link
Member

edolstra commented Apr 7, 2020

This is already fixed in #730 .

@edolstra edolstra closed this Apr 7, 2020
@Ma27
Copy link
Member Author

Ma27 commented Apr 7, 2020

@edolstra no it isn't. Building latest Hydra master with pkgs.nixFlakes from a recent nixpkgs master fails with the following errors (that were fixed in this PR):

hydra> queue-monitor.cc: In lambda function:
hydra> queue-monitor.cc:175:34: error: 'using element_type = class nix::Store' {aka 'class nix::Store'} has no member named 'printStorePathh'; did you mean 'printStorePath'?
hydra> 175 |                      localStore->printStorePathh(ex.step->drvPath));
hydra> |                                  ^~~~~~~~~~~~~~~
hydra> |                                  printStorePath
hydra> queue-monitor.cc:176:74: error: expected primary-expression before '>' token
hydra> 176 |                 if (!res[0].is_null()) propagatedFrom = res[0].as<BuildID>();
hydra> |                                                                          ^
hydra> queue-monitor.cc:176:76: error: expected primary-expression before ')' token
hydra> 176 |                 if (!res[0].is_null()) propagatedFrom = res[0].as<BuildID>();
hydra> |                                                                            ^
hydra> queue-monitor.cc:179:55: error: 'class std::unique_ptr<nix::Derivation>' has no member named 'outputs'
hydra> 179 |                     for (auto & output : ex.step->drv.outputs) {
hydra> |                                                       ^~~~~~~
hydra> queue-monitor.cc:184:66: error: expected primary-expression before '>' token
hydra> 184 |                             propagatedFrom = res[0][0].as<BuildID>();
hydra> |                                                                  ^
hydra> queue-monitor.cc:184:68: error: expected primary-expression before ')' token
hydra> 184 |                             propagatedFrom = res[0][0].as<BuildID>();
hydra> |                                                                    ^
hydra> builder.cc: In member function 'void State::failStep(Connection&, Step::ptr, BuildID, const RemoteResult&, Machine::ptr, bool&, bool&)':
hydra> builder.cc:469:46: error: 'class std::unique_ptr<nix::Derivation>' has no member named 'outputPaths'
hydra> 469 |                 for (auto & path : step->drv.outputPaths())
hydra> |                                              ^~~~~~~~~~~
hydra> hydra-queue-runner.cc: In member function 'unsigned int State::createBuildStep(pqxx::work&, time_t, BuildID, Step::ptr, const string&, BuildStatus, const string&, BuildID)':
hydra> hydra-queue-runner.cc:261:20: error: 'class std::unique_ptr<nix::Derivation>' has no member named 'platform'
hydra> 261 |          step->drv.platform,
hydra> |                    ^~~~~~~~
hydra> hydra-queue-runner.cc:270:36: error: 'class std::unique_ptr<nix::Derivation>' has no member named 'outputs'
hydra> 270 |     for (auto & output : step->drv.outputs)
hydra> |                                    ^~~~~~~
hydra> hydra-queue-runner.cc: In member function 'bool State::checkCachedFailure(Step::ptr, Connection&)':
hydra> hydra-queue-runner.cc:455:34: error: 'class std::unique_ptr<nix::Derivation>' has no member named 'outputPaths'
hydra> 455 |     for (auto & path : step->drv.outputPaths())
hydra> |                                  ^~~~~~~~~~~

@Ma27 Ma27 mentioned this pull request Apr 7, 2020
Merged
Mic92 added a commit to Mic92/hydra that referenced this pull request Apr 9, 2020
@Mic92
add github ci tests
4ce9f02 
To avoid breakages as in: NixOS#731
@Mic92 Mic92 mentioned this pull request Apr 9, 2020
Merged
Mic92 added a commit to Mic92/hydra that referenced this pull request Apr 9, 2020
@Mic92
add github ci tests
828f686 
To avoid breakages as in: NixOS#731
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @kquick @Mic92 @edolstra