nixos/meilisearch: init #84578

Br1ght0ne · 2020-04-07T09:20:23Z

Motivation for this change

Things done

Br1ght0ne · 2020-04-08T12:15:35Z

aanderse · 2020-04-08T12:17:48Z

nixos/modules/misc/ids.nix

@@ -346,6 +346,7 @@ in
      zoneminder = 314;
      paperless = 315;
      #mailman = 316;  # removed 2019-08-30
+      meilisearch = 317;


https://github.com/NixOS/rfcs/blob/master/rfcs/0052-dynamic-ids.md

aanderse · 2020-04-08T12:19:53Z

nixos/modules/services/search/meilisearch.nix

+  options.services.meilisearch = {
+    enable = mkEnableOption "MeiliSearch - a RESTful search API";
+
+    package = mkOption {


Unless there are multiple options or variants of the melisearch package there isn't any real point to this.

aanderse · 2020-04-08T12:20:33Z

nixos/modules/services/search/meilisearch.nix

+
+    environment.systemPackages = [ cfg.package ];
+
+    users = {


You might consider simplifying and using DynamicUser for this.

aanderse · 2020-04-08T12:21:02Z

nixos/modules/services/search/meilisearch.nix

+        uid = config.ids.uids.meilisearch;
+        description = "MeiliSearch daemon user";
+        home = cfg.dbPath;
+        createHome = true;


Use either serviceConfig.StateDirectory or systemd.tmpfiles.rules to provision these types of directories.

aanderse · 2020-04-08T12:21:27Z

nixos/modules/services/search/meilisearch.nix

+      };
+      serviceConfig = {
+        ExecStart = "${cfg.package}/bin/meilisearch";
+        User = "meilisearch";


You didn't specify Group.

aanderse · 2020-04-08T12:21:55Z

nixos/modules/services/search/meilisearch.nix

+      type = types.enum [ "development" "production" ];
+    };
+
+    masterKey = mkOption {


This isn't a secret key, right?

aanderse · 2020-04-08T12:22:44Z

nixos/modules/services/search/meilisearch.nix

+      type = types.port;
+    };
+
+    dbPath = mkOption {


If this is just internal application state I'd highly suggest using DynamicUser and then removing this option.

Reviewed-by: Aaron Andersen <aanderse@users.noreply.github.com>

stale · 2020-10-11T01:02:32Z

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

happysalada · 2021-09-06T07:25:06Z

@aanderse I'm taking this over. This is 90% complete though. I was thinking rather than just copying and pasting, that we could merge this and I could add the finishing touches on top. (this would keep attribution).

Just to detail what I think is still missing in this PR

it needs an assertion that when release mode is production, you need to have a master key
masterKey is indeed a secret. I'm pondering the best way to handle this. I've open an issue upstream for them to allow secrets to be read from files https://github.com/meilisearch/MeiliSearch/issues/1668
I'm not sure we need environment.systemPackages to include meilisearch
There are probably 2-3 environment variables missing https://docs.meilisearch.com/reference/features/configuration.html#dumps-destination

Responding to a few comments

I think it makes sense to keep the package option here, since the package can be compiled with a different feature set

mohe2015 · 2021-09-06T10:32:34Z

Wouldn't it work to just base your PR on top of this one and then squash merge. Or amend to the commit and add yourself as co-author (or the other way around)?

happysalada · 2021-09-06T15:34:27Z

sure, let me try to make a PR based off those 2 commits.

Br1ght0ne · 2021-09-07T09:35:11Z

@happysalada Let me know if I can help in any way. I'm also fine with closing this PR in favor of yours.

happysalada · 2021-09-07T11:25:35Z

don't worry about it, I can cherry pick those commits, not a problem at all.
Thanks again for making those in the first place !

happysalada · 2021-09-08T07:41:39Z

Just opened a PR here #137078

Br1ght0ne requested a review from infinisil as a code owner April 7, 2020 09:20

ofborg bot added 6.topic: nixos 8.has: module (update) ofborg-internal-error labels Apr 7, 2020

Br1ght0ne force-pushed the nixos-module-meilisearch branch from dfb0a94 to e4ff093 Compare April 7, 2020 10:01

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Apr 7, 2020

Br1ght0ne force-pushed the nixos-module-meilisearch branch from e4ff093 to 66e8556 Compare April 7, 2020 10:13

grahamc removed the ofborg-internal-error label Apr 7, 2020

Br1ght0ne force-pushed the nixos-module-meilisearch branch from 66e8556 to b0c3876 Compare April 7, 2020 15:38

aanderse requested changes Apr 8, 2020

View reviewed changes

Br1ght0ne force-pushed the nixos-module-meilisearch branch 2 times, most recently from 5f9df8f to 957c220 Compare April 8, 2020 13:06

Br1ght0ne added 2 commits April 14, 2020 01:02

nixos/meilisearch: init

5844ea8

Reviewed-by: Aaron Andersen <aanderse@users.noreply.github.com>

nixosTests.meilisearch: init

4cc2d55

Br1ght0ne force-pushed the nixos-module-meilisearch branch from 957c220 to 4cc2d55 Compare April 13, 2020 22:53

ofborg bot added 10.rebuild-darwin: 0 10.rebuild-linux: 1 and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Apr 13, 2020

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 11, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 6, 2021

Br1ght0ne closed this Sep 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

nixos/meilisearch: init #84578

nixos/meilisearch: init #84578

Br1ght0ne commented Apr 7, 2020

Br1ght0ne commented Apr 8, 2020

aanderse Apr 8, 2020

aanderse Apr 8, 2020

aanderse Apr 8, 2020

aanderse Apr 8, 2020

aanderse Apr 8, 2020

aanderse Apr 8, 2020

aanderse Apr 8, 2020

stale bot commented Oct 11, 2020

happysalada commented Sep 6, 2021

mohe2015 commented Sep 6, 2021

happysalada commented Sep 6, 2021

Br1ght0ne commented Sep 7, 2021

happysalada commented Sep 7, 2021

happysalada commented Sep 8, 2021

nixos/meilisearch: init #84578

nixos/meilisearch: init #84578

Conversation

Br1ght0ne commented Apr 7, 2020

Motivation for this change

Things done

Br1ght0ne commented Apr 8, 2020

aanderse Apr 8, 2020

Choose a reason for hiding this comment

aanderse Apr 8, 2020

Choose a reason for hiding this comment

aanderse Apr 8, 2020

Choose a reason for hiding this comment

aanderse Apr 8, 2020

Choose a reason for hiding this comment

aanderse Apr 8, 2020

Choose a reason for hiding this comment

aanderse Apr 8, 2020

Choose a reason for hiding this comment

aanderse Apr 8, 2020

Choose a reason for hiding this comment

stale bot commented Oct 11, 2020

happysalada commented Sep 6, 2021

mohe2015 commented Sep 6, 2021

happysalada commented Sep 6, 2021

Br1ght0ne commented Sep 7, 2021

happysalada commented Sep 7, 2021

happysalada commented Sep 8, 2021