Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update biblesync+sword #84631

Merged
merged 2 commits into from Apr 15, 2020
Merged

Update biblesync+sword #84631

merged 2 commits into from Apr 15, 2020

Conversation

AndersonTorres
Copy link
Member

@AndersonTorres AndersonTorres commented Apr 7, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres AndersonTorres mentioned this pull request Apr 7, 2020
Closed
10 tasks
teto
teto reviewed Apr 14, 2020
View reviewed changes
pkgs/development/libraries/sword/default.nix Outdated
license = licenses.gpl2;
maintainers = [ maintainers.piotr maintainers.AndersonTorres ];
maintainers = with maintainers; [ piotr AndersonTorres ];
platforms = platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that a fix ? or a workaround ? ihttp://www.crosswire.org/faq/#Questions_about_the_platforms_our_software_runs_upon seems to suggest a mac version is ok

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know, and I have no Mac to test it.

Maybe unix is OK here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just concerned mac users would be suprised not being able to run it anymore. Did it fail on the darwin CI ?

@AndersonTorres AndersonTorres merged commit 36b4814 into NixOS:master Apr 15, 2020
@AndersonTorres AndersonTorres deleted the update-biblesync+sword branch November 30, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto left review comments

@doronbehar doronbehar doronbehar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AndersonTorres @teto @doronbehar