factorio-{,headless}-experimental: 17.79 -> 18.26 #84523
Merged
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
requested changes
Apr 6, 2020
There was a problem hiding this comment.
I think you meant xorg, not xlibs.
However, does it still work if you directly specify the libs as is done for libGL, libX11, etc.?
EDIT: Ah, xlibs is an alias for xorg. But it fails because ofborg has a step that evals without aliases, which means you have to use xorg directly.
erictapen
force-pushed
the
factorio-18.17
branch
from
5a38191 to
74d6a66
Compare
ofborg
bot
added
11.by: package-maintainer
This comment has been minimized.
This comment has been minimized.
|
Yes, probably. Without username/token for the non-headless/demo builds you probably get the hash of the 403 site despite the actual download? |
|
Looks about right, but in the meantime 0.18.18 is out. |
erictapen
force-pushed
the
factorio-18.17
branch
from
74d6a66 to
c1c2aad
Compare
erictapen
changed the title
Baughn
approved these changes
Apr 11, 2020
NickHu
requested changes
May 24, 2020
erictapen
changed the title
also added myself as maintainer
|
Welll… |
Baughn
approved these changes
May 24, 2020
|
Thanks ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
18.17is the current experimental version on the factorio website.Things done
Added some libraries that were missing when I started the game. Also added myself as maintainer.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)