Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorio-{,headless}-experimental: 17.79 -> 18.26 #84523

Merged
merged 1 commit into from May 25, 2020

Conversation

erictapen
Copy link
Member

Motivation for this change

18.17 is the current experimental version on the factorio website.

Things done

Added some libraries that were missing when I started the game. Also added myself as maintainer.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you meant xorg, not xlibs.

However, does it still work if you directly specify the libs as is done for libGL, libX11, etc.?

EDIT: Ah, xlibs is an alias for xorg. But it fails because ofborg has a step that evals without aliases, which means you have to use xorg directly.

pkgs/games/factorio/default.nix Outdated Show resolved Hide resolved
pkgs/games/factorio/default.nix Outdated Show resolved Hide resolved
@cole-h

This comment has been minimized.

@erictapen
Copy link
Member Author

Yes, probably. Without username/token for the non-headless/demo builds you probably get the hash of the 403 site despite the actual download?

@Baughn
Copy link
Contributor

Baughn commented Apr 9, 2020

Looks about right, but in the meantime 0.18.18 is out.

@erictapen erictapen changed the title factorio-{,headless}-experimental: 17.79 -> 18.17 factorio-{,headless}-experimental: 17.79 -> 18.18 Apr 10, 2020
Copy link
Contributor

@Baughn Baughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this looks fine. I'm not running Linux on the desktop at the moment, unfortunately.

Copy link
Contributor

@NickHu NickHu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI latest version is now 0.18.26

@erictapen erictapen changed the title factorio-{,headless}-experimental: 17.79 -> 18.18 factorio-{,headless}-experimental: 17.79 -> 18.26 May 24, 2020
also added myself as maintainer
@erictapen
Copy link
Member Author

Welll…

@ofborg ofborg bot requested a review from Baughn May 24, 2020 20:13
@veprbl veprbl merged commit 7a2307d into NixOS:master May 25, 2020
@erictapen
Copy link
Member Author

Thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants