Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamspeak_server: 3.11.0 -> 3.12.1 #84650

Merged
merged 2 commits into from Apr 12, 2020
Merged

teamspeak_server: 3.11.0 -> 3.12.1 #84650

merged 2 commits into from Apr 12, 2020

Conversation

Gerschtli
Copy link
Contributor

Motivation for this change

Update teamspeak_server.
Replaces/fixes #84641.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Gerschtli Gerschtli mentioned this pull request Apr 7, 2020
Closed
@ofborg ofborg bot requested a review from Shados April 7, 2020 19:07
JeffLabonte
JeffLabonte approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It builds!

@marsam marsam merged commit 537e891 into NixOS:master Apr 12, 2020
@Gerschtli Gerschtli deleted the update/ts3 branch April 12, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffLabonte JeffLabonte JeffLabonte approved these changes

@Shados Shados Awaiting requested review from Shados

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gerschtli @JeffLabonte @marsam